Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove orphan static-files volume from ArgoCD server deployment manifest - Fixes #8714 #9013

Merged
merged 2 commits into from
Apr 20, 2022
Merged

fix: Remove orphan static-files volume from ArgoCD server deployment manifest - Fixes #8714 #9013

merged 2 commits into from
Apr 20, 2022

Conversation

Sea-you
Copy link
Contributor

@Sea-you Sea-you commented Apr 6, 2022 •
edited
Loading

Signed-off-by: Domonkos Cinke seayou@gmail.com

Fixes #8714

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@Sea-you Sea-you mentioned this pull request Apr 6, 2022
Merged
6 tasks
@codecov
Copy link

codecov bot commented Apr 6, 2022 •
edited
Loading

Codecov Report

Merging #9013 (e2995ba) into master (5921e2a) will increase coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9013      +/-   ##
==========================================
+ Coverage   45.07%   45.45%   +0.37%     
==========================================
  Files         212      219       +7     
  Lines       25281    25870     +589     
==========================================
+ Hits        11396    11759     +363     
- Misses      12278    12476     +198     
- Partials     1607     1635      +28
Impacted Files Coverage Δ
applicationset/services/scm_provider/github.go 63.52% <0.00%> (-17.65%) ⬇️
cmd/argocd/commands/admin/project_allowlist.go 30.95% <0.00%> (-16.35%) ⬇️
applicationset/generators/pull_request.go 42.85% <0.00%> (-13.40%) ⬇️
applicationset/generators/scm_provider.go 40.25% <0.00%> (-13.19%) ⬇️
server/server.go 54.07% <0.00%> (-1.51%) ⬇️
server/application/application.go 30.50% <0.00%> (-0.87%) ⬇️
util/helm/cmd.go 28.82% <0.00%> (-0.83%) ⬇️
reposerver/repository/repository.go 59.70% <0.00%> (-0.39%) ⬇️
cmd/argocd/commands/root.go 2.00% <0.00%> (-0.09%) ⬇️
cmd/argocd/commands/login.go 2.29% <0.00%> (-0.02%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5921e2a...e2995ba. Read the comment docs.

@crenshaw-dev
Copy link
Member

@Sea-you thanks! Can you run make codegen? I think the commit message will also need to have fix: added to the beginning.

@Sea-you Sea-you force-pushed the remove/static-files-server-manifest branch from 41ec14e to 7162e78 Compare April 11, 2022 11:12
cu12 and others added 2 commits April 20, 2022 09:40
@cu12 @Sea-you
fix: Remove orphan static-files volume from ArgoCD server deployment …
f8b663b 
…manifest

Signed-off-by: Domonkos Cinke <seayou@gmail.com>
@Sea-you
fix: Make codegen
e2995ba 
Signed-off-by: Domonkos Cinke <seayou@gmail.com>
@Sea-you Sea-you force-pushed the remove/static-files-server-manifest branch from 9fa8fd8 to e2995ba Compare April 20, 2022 07:41
@Sea-you
Copy link
Contributor Author

Sea-you commented Apr 20, 2022

@crenshaw-dev ptal :)

crenshaw-dev
crenshaw-dev approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@crenshaw-dev crenshaw-dev merged commit 86d04de into argoproj:master Apr 20, 2022
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
@Sea-you @cu12 @wojtekidd
fix: Remove orphan static-files volume from ArgoCD server deployment …
15876f4 
…manifest - Fixes argoproj#8714 (argoproj#9013)

* fix: Remove orphan static-files volume from ArgoCD server deployment manifest

Signed-off-by: Domonkos Cinke <seayou@gmail.com>

* fix: Make codegen

Signed-off-by: Domonkos Cinke <seayou@gmail.com>

Co-authored-by: Domonkos Cinke <domonkos.cinke@namecheap.com>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Volume static-files present and volumemount not referenced
3 participants
@Sea-you @crenshaw-dev @cu12